MA0008: Use proper blittable type check instead of IsReferenceType#1062
Merged
Conversation
The analyzer previously only checked IsReferenceType, which incorrectly flagged structs with non-blittable value-type fields (bool, char, decimal). Add IsBlittableType() extension that checks the complete set of blittable types: byte, sbyte, short, ushort, int, uint, long, ulong, float, double, IntPtr, UIntPtr, pointers, enums, and structs with only blittable fields.
This was referenced Mar 26, 2026
Closed
Merged
IhateTrains
added a commit
to ParadoxGameConverters/ImperatorToCK3
that referenced
this pull request
Mar 27, 2026
Updated [Meziantou.Analyzer](https://github.com/meziantou/Meziantou.Analyzer) from 3.0.26 to 3.0.28. <details> <summary>Release notes</summary> _Sourced from [Meziantou.Analyzer's releases](https://github.com/meziantou/Meziantou.Analyzer/releases)._ ## 3.0.28 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.28> ## What's Changed * MA0008: Use proper blittable type check instead of IsReferenceType by @meziantou in meziantou/Meziantou.Analyzer#1062 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.27...3.0.28 ## 3.0.27 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/3.0.27> ## What's Changed * MA0190: Suggest converting [GeneratedRegex] partial methods to partial properties (C# 13+) by @Copilot in meziantou/Meziantou.Analyzer#1060 **Full Changelog**: meziantou/Meziantou.Analyzer@3.0.26...3.0.27 Commits viewable in [compare view](meziantou/Meziantou.Analyzer@3.0.26...3.0.28). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
This was referenced Mar 27, 2026
Closed
Merged
This was referenced May 6, 2026
Closed
Closed
Closed
Closed
Closed
This was referenced May 15, 2026
Closed
Open
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The MA0008 (
UseStructLayoutAttributeAnalyzer) rule is documented to only fire when all struct fields are blittable, but the implementation only checkedmember.Type.IsReferenceType. This meant it would incorrectly flag structs with non-blittable value-type fields likebool,char, anddecimal.Changes
New
IsBlittableType()extension methodAdded to
TypeSymbolExtensions.cs, checking the complete set of blittable types per the .NET specification:byte,sbyte,short,ushort,int,uint,long,ulong,float,double,IntPtr,UIntPtrNon-blittable value types (
bool,char,decimal,DateTime, etc.) correctly returnfalse.Updated analyzer
Replaced the
member.Type.IsReferenceTypecheck inUseStructLayoutAttributeAnalyzerwith!member.Type.IsBlittableType().New tests (11 added)
bool,char,decimalfields → no diagnostic (non-blittable)nint/nuint(IntPtr/UIntPtr),float/doublefields → diagnostic (blittable)All 18 tests pass on both default Roslyn and Roslyn 4.2.